<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100604/">http://git.reviewboard.kde.org/r/100604/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2011, 10:03 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is not working here.</pre>
</blockquote>
<p>On April 10th, 2011, 10:27 a.m., <b>Anton Kreuzkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the problem? Does it not compile? (error-message?) Does it crash? (backtrace?) Or does it simply not work? (what exactly? open a closed tab/restoring the session/both? what does the session-file look like?(is it xml?))</pre>
</blockquote>
<p>On April 18th, 2011, 2:10 p.m., <b>Felix Rohrbach</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is working for me with rekonq-git (at least I found no errors).</pre>
</blockquote>
<p>On April 20th, 2011, 5:08 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not working in the sense that no history is saved. At least I don't see it on restore.</pre>
</blockquote>
<p>On April 24th, 2011, 12:15 p.m., <b>Anton Kreuzkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does the session-file exist (should be ~/.kde/share/apps/rekonq/session)? How does it look like?</pre>
</blockquote>
<p>On April 28th, 2011, 10:17 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried reinstalling your patch, deleting my session file and now the history save/restore works well. Some problems with previous version? Maybe.
I don't understand the changes you did to the code. What's the goal of changing the "recentlyClosedTabs" structure? Can it be (re)moved at all in the session manager? And why are you using it to store the tabs information? Moreover, your changes broke the closed tabs contextual menu and the closed tabs page.</pre>
</blockquote>
<p>On May 2nd, 2011, 10:42 p.m., <b>Anton Kreuzkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>I tried reinstalling your patch, deleting my session file and now the history save/restore works well. Some problems with previous version? Maybe.
Nice to hear that it's solved now :)
>I don't understand the changes you did to the code.
Well I can try to explain you, whatever you don't understand. Comments at the exact places in the code would be helpful.
>What's the goal of changing the "recentlyClosedTabs" structure?
Well it restores the history of closed tabs as well..
>Can it be (re)moved at all in the session manager?
I don't quite understand what you mean by that. I can only say, I tried to change the structure of the code (where which methods are, etc.) as little as possible.
>And why are you using it to store the tabs information?
What exactly? If you mean the Buffer with the history, it's the only way to save the history, so that I can restore it later on.
>Moreover, your changes broke the closed tabs contextual menu and the closed tabs page.
More information would be desirable, I will try to fix every bug, that occurs to me. I can just say, everything I can test at the moment (which is just the context-menu) works here. But I can't remember any difficulties with the closed tabs page.
But I will test it again with a current checkout, tomorrow ;)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can read your code and understand what a change does. What I don't see is WHY you did.
I tried firefox and chrome and I didn't see the feature of remember closed tabs history on restart. In general, I think this is a "not wanted" feature (too much intrusive and different from habits: I sure cannot remember last closed tab from previous session). So, I'm ok with the restoring tab history on reopening last closed tab. I don't like the restore tabs history "session" part.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On April 8th, 2011, 2:51 p.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated April 8, 2011, 2:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restore the history of the tab when restoring a tab from the list of closed tabs, by open last closed tab or by restoring the session.
Therefore I ported the session-file to xml, as it allows more complex session-files (which is also needed for multiple sessions support).
(Doesn't require a qtwebkit-patch anymore)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested and everything seems to work fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainview.h <span style="color: grey">(acc2d8c)</span></li>
<li>src/application.cpp <span style="color: grey">(1fe936f)</span></li>
<li>src/history/historymanager.h <span style="color: grey">(eb8d78d)</span></li>
<li>src/mainview.cpp <span style="color: grey">(b34acc3)</span></li>
<li>src/newtabpage.cpp <span style="color: grey">(a598066)</span></li>
<li>src/sessionmanager.h <span style="color: grey">(2297290)</span></li>
<li>src/sessionmanager.cpp <span style="color: grey">(68bc635)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(1ab357f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100604/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>