<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101171/">http://git.reviewboard.kde.org/r/101171/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uhm... this patch is "monumental". And sincerely I don't like merging things like this. First of all this is claimed to be the "new" hybrid home page. But in reality, this patch changes (in sparse order):
- the "about" scheme handling (and more?)
- a "new" scheme management (the "rekonq" one: to hide! Is this really needed?)
- some things in the bookmarks (not well identified)
- some things in the history (not well identified)
- introduces a new download manager
- changes the way downloads history is managed
and finally...
- the new "hybrid" page (plus some fixes, changes not well identified through the commits messages).
So, if this is an ALL or NOTHING patch, I vote for NOTHING, sorry. I expect here the merges of the individual new features as standalones (eg: the download manager and the "scheme" handling change) and finally the "hybrid page" merge as "easy and NOT invasive" addiction. </pre>
<br />
<p>- Andrea</p>
<br />
<p>On April 21st, 2011, 6 p.m., Pierre Rossi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Pierre Rossi.</div>
<p style="color: grey;"><i>Updated April 21, 2011, 6 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The branch is here:
http://gitorious.org/~elproxy/rekonq/elproxys-rekonq/commits/hybridRebased
I rebased the whole beast again on top of master, but I suspect it'll need rebasing again by the time it's actually going to be integrated (which I volunteer for if that's the case). Since so many things are touched all over the place it conflicts easily with new changes in master.
I think a diff would be useless at this point since it'd spread on so many pages, so I guess it's easier to just checkout the branch and look at the commits with git log (-p might be helpful) and basically test and see what the change is all about.
There are still quirks (i.e. some things that currently work might break) but nothing that should be impossible to fix really, and I wouldn't mind getting bug reports on this at this point.
A big thanks to Benjamin for all the work he put into this.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">erm, no autotests for the individual components as of now, but I'm still considering it and thinking about how to do this properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101171/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>