<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100316/">http://git.reviewboard.kde.org/r/100316/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100316/diff/4/?file=9849#file9849line290" style="color: black; font-weight: bold; text-decoration: underline;">src/application.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">MainWindow *Application::mainWindow()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">290</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">s</span>_historyManager</span> <span class="o">=</span> <span class="k">new</span> <span class="n">HistoryManager</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">267</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">m</span>_historyManager</span> <span class="o">=</span> <span class="k">new</span> <span class="n">HistoryManager</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aren't we missing the parent object here?</pre>
</div>
<br />
<p>- Andrea</p>
<br />
<p>On February 22nd, 2011, 1:48 p.m., Pierre Rossi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Benjamin Poulain.</div>
<div>By Pierre Rossi.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2011, 1:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I believe we don't need static members in QWeakPointers for all the *Managers, static getter functions would do the job.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"compiles and runs" ™</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=N/A">N/A</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.h <span style="color: grey">(b30e337)</span></li>
<li>src/application.cpp <span style="color: grey">(9702c13)</span></li>
<li>src/bookmarks/bookmarkowner.cpp <span style="color: grey">(b7aa4a4)</span></li>
<li>src/bookmarks/bookmarkprovider.cpp <span style="color: grey">(e4fb9e3)</span></li>
<li>src/bookmarks/bookmarkspanel.cpp <span style="color: grey">(1763a1e)</span></li>
<li>src/bookmarks/bookmarkstoolbar.cpp <span style="color: grey">(e239e23)</span></li>
<li>src/bookmarks/bookmarkstreemodel.cpp <span style="color: grey">(f13cee4)</span></li>
<li>src/history/historymodels.cpp <span style="color: grey">(d9d3efe)</span></li>
<li>src/history/historypanel.cpp <span style="color: grey">(d1b02c4)</span></li>
<li>src/iconmanager.cpp <span style="color: grey">(f5b60ea)</span></li>
<li>src/mainview.cpp <span style="color: grey">(dfa202d)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(24dc865)</span></li>
<li>src/networkaccessmanager.cpp <span style="color: grey">(118d4b2)</span></li>
<li>src/newtabpage.cpp <span style="color: grey">(7dcc958)</span></li>
<li>src/opensearch/searchengine.cpp <span style="color: grey">(f407789)</span></li>
<li>src/paneltreeview.cpp <span style="color: grey">(e44fa5f)</span></li>
<li>src/previewselectorbar.cpp <span style="color: grey">(c8ab5b0)</span></li>
<li>src/protocolhandler.cpp <span style="color: grey">(6dfc33a)</span></li>
<li>src/sessionmanager.cpp <span style="color: grey">(87f25f4)</span></li>
<li>src/settings/generalwidget.cpp <span style="color: grey">(0128830)</span></li>
<li>src/settings/settingsdialog.cpp <span style="color: grey">(84c6da1)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(be20ecd)</span></li>
<li>src/urlbar/bookmarkwidget.cpp <span style="color: grey">(4569bc2)</span></li>
<li>src/urlbar/completionwidget.cpp <span style="color: grey">(0d2026a)</span></li>
<li>src/urlbar/listitem.cpp <span style="color: grey">(1794233)</span></li>
<li>src/urlbar/rsswidget.cpp <span style="color: grey">(b29ed0e)</span></li>
<li>src/urlbar/urlbar.cpp <span style="color: grey">(c0edc9d)</span></li>
<li>src/urlbar/urlresolver.h <span style="color: grey">(43a4a43)</span></li>
<li>src/urlbar/urlresolver.cpp <span style="color: grey">(3797f51)</span></li>
<li>src/webicon.cpp <span style="color: grey">(e64db30)</span></li>
<li>src/webpage.cpp <span style="color: grey">(b44b2e4)</span></li>
<li>src/webtab.cpp <span style="color: grey">(c2f0016)</span></li>
<li>src/webview.cpp <span style="color: grey">(18c7a73)</span></li>
<li>src/zoombar.cpp <span style="color: grey">(8679126)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100316/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>