<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100683/">http://git.reviewboard.kde.org/r/100683/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 19th, 2011, 12:11 p.m., <b>Benjamin Poulain</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not a fan of listing every option. When the author of adblock add an option, we will need to update the code.
What about just one field: hasUnsupportedOption set to true if any option is not used by the filter?
Not to mention adblock already takes its share of memory. Don't forget those field will be allocated for each rule.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, memory is a problem, yes. I was thinking about some possible implementation for eg the "image" or the "script" option and I started adding these booleans.. :)
Switching to an "hasUnsupportedOption" check, waiting for the real option implementations.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On February 19th, 2011, 9:57 a.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Benjamin Poulain.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2011, 9:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AdBlock clean up.
With this patch we explicitely allow any option that has not been (yet) fully implemented.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=248045">248045</a>,
<a href="/show_bug.cgi?id=253329">253329</a>,
<a href="/show_bug.cgi?id=265909">265909</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/adblock/adblockrulefallbackimpl.h <span style="color: grey">(ec10ee5)</span></li>
<li>src/adblock/adblockrulefallbackimpl.cpp <span style="color: grey">(ae0e14d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100683/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>