<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100683/">http://git.reviewboard.kde.org/r/100683/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am still not a fan of the patch. I think its complexity is high for what it adds, we can probably do better.
I also don't like the idea of adding a branch because there is a rule, but it is invalid. It does not look very clean IMHO.
Alternative ideas:
-add a AdBlockRuleNullImpl that always return false for ::match(). And create that in AdBlockRule::AdBlockRule() if there are any unsupported options.
-or add AdBlockRule::isValid(). And do not set the m_implementation if there are any unsupported option. The AdBlockManager would not add a rule if it is not valid, so they are never evaluated.
I am also not a fan of comparing lots of string for each rules. What about keeping a QSet of unsupported options?</pre>
<br />
<p>- Benjamin</p>
<br />
<p>On February 19th, 2011, 6:46 p.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Benjamin Poulain.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2011, 6:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AdBlock clean up.
With this patch we explicitely allow any option that has not been (yet) fully implemented.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=248045">248045</a>,
<a href="/show_bug.cgi?id=253329">253329</a>,
<a href="/show_bug.cgi?id=265909">265909</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/adblock/adblockrulefallbackimpl.h <span style="color: grey">(ec10ee5)</span></li>
<li>src/adblock/adblockrulefallbackimpl.cpp <span style="color: grey">(ae0e14d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100683/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>