<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100456/">http://git.reviewboard.kde.org/r/100456/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 3rd, 2011, 12:11 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100456/diff/1/?file=7794#file7794line29" style="color: black; font-weight: bold; text-decoration: underline;">src/data/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl">home</span>.html</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl">index</span>.html</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let me guess: files added here ARE the new hybrid home page. What do you think about dividing them in 2 groups:
1) the ones needed every time to show the page.
EG:
INSTALL( FILE index.html *.js
DESTINATION ${DATA_INSTALL_DIR}/rekonq/htmls )
2) the ones the "designers" can change to theme rekonq
EG:
INSTALL ( FILE rekonq_newtab.css ui.css
DESTINATION ${DATA_INSTALL_DIR}/rekonq/$THEMENAME
What do you think?</pre>
</blockquote>
<p>On February 3rd, 2011, 10:27 a.m., <b>Benjamin Poulain</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we should do proper theming in the next version. I am affraid we will have a half-baked solution if we rush it now.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, and the split for themes would more likely be ui.js and ui.css for the theme, the rest stays untouched, but we need to make sure that the split is done in a proper way so that theming comes with all the power one would expect. definitely for next version, since there's still more important work on this to get it in shape for the release already.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 3rd, 2011, 12:11 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100456/diff/1/?file=7854#file7854line86" style="color: black; font-weight: bold; text-decoration: underline;">src/webpage.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">85</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">copyToTempFileResult</span><span class="p">(</span><span class="n">KJob</span><span class="o">*</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why did you remove this? Have you notice WHERE it is called (webpage.cpp:488) and WHY?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice catch !
That's definitely a mistake, I didn't see this change (possibly open in an editor and I cleared the line by accident while looking at the other screen) sneak its way in my diff for the post rebase fixes and committed too quickly with -a -m</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 3rd, 2011, 12:11 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100456/diff/1/?file=7855#file7855line767" style="color: black; font-weight: bold; text-decoration: underline;">src/webpage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void WebPage::setupHybridStuff()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">763</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">settings</span><span class="p">()</span><span class="o">-></span><span class="n">setAttribute</span><span class="p">(</span><span class="n">QWebSettings</span><span class="o">::</span><span class="n">JavascriptEnabled</span><span class="p">,</span> <span class="kc">true</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What does it happen in case users have js disabled?
Is it automatically re-enabled every time they visit a rekonq page?
...
Let me guess.. the JavaScriptGuard fixes this.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup, you got that right: JavaScript is key for the new approach (pretty much all the logic is in JavaScript), and we know it's there in any case, so we simply enable it temporarily for that page when navigating to it, and the guard makes sure it's disabled if it needs to be on tear down.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 3rd, 2011, 12:11 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100456/diff/1/?file=7860#file7860line111" style="color: black; font-weight: bold; text-decoration: underline;">src/webview.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">111</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">//Q_DECLARE_METATYPE(WebView)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure I understood the need for this. Can you please argument a bit?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops again, one of those tired late night commits from the end, this comment slipped through...
Ok, gonna fix both of these glitches.</pre>
<br />
<p>- Pierre</p>
<br />
<p>On January 28th, 2011, 9:20 p.m., Pierre Rossi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq, Andrea Diamantini, Lionel Chauvin, and Benjamin Poulain.</div>
<div>By Pierre Rossi.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2011, 9:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As expected, the diff is pretty huge, and since the rebase started to look messy, I actually dropped some of the earlier changes from before we decided to go hybrid and made a new branch, so here it is:
http://gitorious.org/~elproxy/rekonq/elproxys-rekonq/commits/hybridRebased</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Tested and works™" :)
Well, there are still a few known issues with fixes to be expected in the next two weeks (for instance the about: to rekonq:// conversion, necessary for WebKit to even request loading the page, isn't perfect and transparent to the user yet).
And the design of the pages (trying to mimic the original as much as possible for now) is not yet totally polished, and that's definitely not set in stone for the future.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(6cf2651)</span></li>
<li>src/application.h <span style="color: grey">(b30e337)</span></li>
<li>src/application.cpp <span style="color: grey">(f38832c)</span></li>
<li>src/data/CMakeLists.txt <span style="color: grey">(f34936b)</span></li>
<li>src/data/bg.png <span style="color: grey">(5ec669a)</span></li>
<li>src/data/bg2.png <span style="color: grey">(1ded269)</span></li>
<li>src/data/bookmarks.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/closedtabs.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/downloads.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/favorites.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/history.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/home.html <span style="color: grey">(df8f409)</span></li>
<li>src/data/images/arrow-down.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/images/arrow-right.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/images/navigation_background.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/images/tile_background.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/index.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/rekonq_newtab.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/tile.gif <span style="color: grey">(32e06ff)</span></li>
<li>src/data/tools.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/ui.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/ui.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/downloadmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/downloadmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/filterurljob.cpp <span style="color: grey">(53b52b7)</span></li>
<li>src/history/historymanager.h <span style="color: grey">(60598ce)</span></li>
<li>src/history/historymanager.cpp <span style="color: grey">(59cc121)</span></li>
<li>src/main.cpp <span style="color: grey">(dcf996e)</span></li>
<li>src/mainview.h <span style="color: grey">(bc8b676)</span></li>
<li>src/mainview.cpp <span style="color: grey">(699103a)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(ece11cc)</span></li>
<li>src/networkaccessmanager.cpp <span style="color: grey">(9d9101b)</span></li>
<li>src/newtabpage.h <span style="color: grey">(be02d9d)</span></li>
<li>src/newtabpage.cpp <span style="color: grey">(7dcc958)</span></li>
<li>src/newtabpage/bookmarkiterator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bookmarkiterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bookmarktab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bookmarktab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bridgeutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bridgeutils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/closedtabs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/closedtabs.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloaditem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloaditem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloadtab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloadtab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoriteitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoriteitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoritestab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoritestab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historyitemiterator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historyitemiterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historytab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historytab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/javascriptguard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/rekonqreply.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/rekonqreply.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/tabobject.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/tabobject.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/previewselectorbar.h <span style="color: grey">(9684a01)</span></li>
<li>src/previewselectorbar.cpp <span style="color: grey">(c8ab5b0)</span></li>
<li>src/protocolhandler.cpp <span style="color: grey">(6dfc33a)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(7a8419a)</span></li>
<li>src/webpage.h <span style="color: grey">(7633b26)</span></li>
<li>src/webpage.cpp <span style="color: grey">(c074f1a)</span></li>
<li>src/websnap.h <span style="color: grey">(e5b550f)</span></li>
<li>src/websnap.cpp <span style="color: grey">(54cf105)</span></li>
<li>src/webtab.h <span style="color: grey">(7b7c3c7)</span></li>
<li>src/webtab.cpp <span style="color: grey">(1305747)</span></li>
<li>src/webview.h <span style="color: grey">(a06a2cb)</span></li>
<li>src/webview.cpp <span style="color: grey">(d3eb2f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100456/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100456/s/60/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/rekonq-favorites_400x100.jpeg" style="border: 1px black solid;" alt="Favorites" /></a>
<a href="http://git.reviewboard.kde.org/r/100456/s/61/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/rekonq-downloads_400x100.jpeg" style="border: 1px black solid;" alt="Downloads" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>