<br><div class="gmail_quote">On Fri, Jan 28, 2011 at 17:33, Benjamin Poulain <span dir="ltr"><<a href="mailto:benjamin.poulain@nokia.com">benjamin.poulain@nokia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hello,<br>
<br>
May I suggest to add some text on <a href="http://rekonq.kde.org/sources" target="_blank">http://rekonq.kde.org/sources</a> to guide<br>
people on contributin to Rekonq?<br>
<br>
I think it is important to guide people on how to do their first<br>
patches. It shows our process is quite complicated and it could be an<br>
objective for us to simplify some particularity so the text can be made<br>
simpler.<br>
<br>
I suggest the following:<br></blockquote><div><br>Indeed, very nice thing to have on the website:<br><br>It seems you hesitated a bit between "Rekonq" or "The Rekonq project" though, I guess it should read:<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
-------------------------------------<br>
<br>
<h1>Contributing to Rekonq</h1><br>
<br> Rekonq is open to all contributions, from small fixes to full time<br>
commitment. The patches should follow the vision of the project, and the<br>
quality defined for the code.<br>
<br>
The main communication channels for developers are<br>
* the mailing list <a href="https://mail.kde.org/mailman/listinfo/rekonq" target="_blank">https://mail.kde.org/mailman/listinfo/rekonq</a><br>
* IRC: #rekonq on Freenode<br></blockquote><div><i>Here I'd add:</i> <br> Don't hesitate to discuss your plans of adding features there beforehand.<br></div><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
To compile Rekonq, you need recent kdelibs with the development<br>
headers. Here are the commands to compile and install Rekonq from source:<br>
<br>
<pre><br>
git clone git://<a href="http://git.kde.org/rekonq.git" target="_blank">git.kde.org/rekonq.git</a><br>
cd rekonq<br>
cmake .<br>
make<br>
sudo make install<br>
</pre><br>
<br>
When making a patch, follow the KDE coding style:<br>
<a href="http://techbase.kde.org/Policies/Kdelibs_Coding_Style" target="_blank">http://techbase.kde.org/Policies/Kdelibs_Coding_Style</a> except for braces<br>
which have to be on the next line:<br>
<br>
<pre><br>
// Correct<br>
if (foo)<br>
{<br>
<br>
while (bar)<br>
{<br>
<br>
<br>
// Wrong:<br>
if (foo) {<br>
</pre><br>
<br>
<br>
Once you made a patch, use "git commit" to create a commit. The commit<br>
message needs to be a clear description of the change introduced by the<br>
patch. If necessary, split the change in smaller patches introducing one<br>
feature at the time.<br>
More information about commit messages can be found here:<br>
<a href="http://techbase.kde.org/Projects/rekonq/Git_with_rekonq_HowTo" target="_blank">http://techbase.kde.org/Projects/rekonq/Git_with_rekonq_HowTo</a><br>
<br>
<br>
Every non-trivial patch needs to be reviewed by at least one developer<br>
of the project. This is done on the review board:<br>
<a href="http://git.reviewboard.kde.org/" target="_blank">http://git.reviewboard.kde.org/</a><br>
Create the text verson of patch with git format-patch, and submit it on<br>
the review board. To create an account on review board, use<br>
<a href="https://identity.kde.org/" target="_blank">https://identity.kde.org/</a>.<br>
<br>
Making a perfect patch usually takes a few reviewing iterations. Do not<br>
give up if your patch is not accepeted immediately. If the review has no<br>
comments after a few days, ask why on #rekonq.<br>
<br>
Once a reviewer accept a patch, he will integrate it for you.<br>
<br>
Regular contributors are granted commit rights so they can pushes patch<br>
themself. The review process is mandatory for everyone, including commiters.<br>
_______________________________________________<br>
rekonq mailing list<br>
<a href="mailto:rekonq@kde.org">rekonq@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/rekonq" target="_blank">https://mail.kde.org/mailman/listinfo/rekonq</a><br></blockquote><div><br><br>No other remarks really. I think it'd be a great page to have. :)<br>
<br>Cheers,<br>--<br>Pierre<br></div></div><br>