<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100286/">http://git.reviewboard.kde.org/r/100286/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 17th, 2011, 4:25 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like this, there is just one small thing to fix before merge. Or did you discuss something different in ml? I couldn't follow it..</pre>
</blockquote>
<p>On January 17th, 2011, 4:30 p.m., <b>Furkan Üzümcü</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They talked about adding a button to the url bar like the add bookmark button. But nobody said anything about it in ml. I'm updating the patch.</pre>
</blockquote>
<p>On January 17th, 2011, 4:37 p.m., <b>Lionel Chauvin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought about reintroduce an "add bookmark" popup that allow to choose the bookmark folder and that propose to add this bookmark in the favorite too (with a checkbox).</pre>
</blockquote>
<p>On January 17th, 2011, 4:54 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like that, Lionel. But I don't think it lets this be "unuseful". I'm for merging if you and ... (who implemented this?).. have no objections. Do you?</pre>
</blockquote>
<p>On January 17th, 2011, 5:14 p.m., <b>Lionel Chauvin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With this patch, what the user will do ?
He will open a tab,
visit the website he want add as preview,
click on the new tab button,
add a preview,
click on the preview,
go to the previous tab,
copy the url,
go the the new tab page,
paste the url.
validate.
I think the feature of this patch were not needed if the previewselectorbar were global to all tabs like it was when Mathieu Gicquel introduced it.
With this workflow the user will:
open a tab,
visit the website he want add as preview,
click on the new tab button,
add a preview,
click on the preview,
go to the previous tab,
validate.
</pre>
</blockquote>
<p>On January 17th, 2011, 5:20 p.m., <b>Furkan Üzümcü</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You got a point,
but what if user wants to add a page he/she hasn't opened to favorites?</pre>
</blockquote>
<p>On January 17th, 2011, 5:31 p.m., <b>Lionel Chauvin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if the page is not opened, I assume the user has the url in the clipboard.
He just open a new tab page,
click on add preview
click on the preview
paste the url in the urlbar
press enter
validate
</pre>
</blockquote>
<p>On January 17th, 2011, 5:35 p.m., <b>Lionel Chauvin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I say "add preview" I mean "add favorite" in the favorite page.
I just think about the workflow:
why "add favorite" add a empty preview ? why it does not only open the previewselectorbar ? It would remove one click.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems we are considering some different use cases:
1) user is visiting a page and he'd like adding it as favorite. We actually have no one-click solution for this. The "love" button could be perfect here. Or the revisited "add bookmark" popup.
2) user is visiting his about:favorites page and likes to set/order/cleanup it. Here current solution just works. Furkan's patch adds an extra case to let life easier when user just knows his favorites urls or have it/them in the clipboard.
The "add favorite" button has to open the previewselectorbar. Lionel is right here.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On January 17th, 2011, 5:11 p.m., Furkan Üzümcü wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2011, 5:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added support for entering link directly into the Favorites section in the New Tab .</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Tested and works!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/newtabpage.cpp <span style="color: grey">(7dcc958)</span></li>
<li>src/previewselectorbar.h <span style="color: grey">(9684a01)</span></li>
<li>src/previewselectorbar.cpp <span style="color: grey">(c8ab5b0)</span></li>
<li>src/websnap.h <span style="color: grey">(e5b550f)</span></li>
<li>src/websnap.cpp <span style="color: grey">(54cf105)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100286/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>