<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100396/">http://git.reviewboard.kde.org/r/100396/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 15th, 2011, 10:53 p.m., <b>Benjamin Poulain</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100396/diff/1/?file=7140#file7140line79" style="color: black; font-weight: bold; text-decoration: underline;">src/history/historymanager.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">dateTime</span> <span class="o">></span> <span class="n">other</span><span class="p">.</span><span class="n">dateTime</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span><span class="hl"> </span><span class="n"><span class="hl">visitCount</span></span><span class="hl"> </span><span class="o"><span class="hl">></span></span><span class="hl"> </span><span class="n"><span class="hl">other</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">visitCount</span></span><span class="hl"> </span><span class="o"><span class="hl">&&</span></span> <span class="n">dateTime</span> <span class="o">></span> <span class="n">other</span><span class="p">.</span><span class="n">dateTime</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just an idea...
What about a weigthed sum of both to determine the order?
With an absolute measure of either one you can end up in those situations:
priority visit: a web site visited 3 times 2 months ago will appear before something you saw yersterday
priority date: something you saw yesterday appear before something you look every day
So it might be nice to take both into account?</pre>
</blockquote>
<p>On January 16th, 2011, 9:34 a.m., <b>Lionel Chauvin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried:
return (visitCount - other.visitCount) + dateTime.daysTo(other.dateTime) > 0;
but it doesn't work fine.
Any idea ?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about each item as:
qreal ::relevance() const;
Computed as : ln(visitCount) - ln(dateSinceLastVisit)? (count be negative...).
So we have equal relevance with exponential decay? We can then weight one or the other to favor visit count or date?</pre>
<br />
<p>- Benjamin</p>
<br />
<p>On January 15th, 2011, 8:23 p.m., Lionel Chauvin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Lionel Chauvin.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2011, 8:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Items in the completionlist are sorted by visit count instead of last visit date</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/history/historymanager.h <span style="color: grey">(a4099de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100396/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>