<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100315/">http://git.reviewboard.kde.org/r/100315/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 11th, 2011, 5:10 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think this really solves the situation. You should probably limit the "recentlyClosedTabs" list, instead.</pre>
</blockquote>
<p>On January 11th, 2011, 5:14 p.m., <b>Furkan Üzümcü</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't it used for the closed tabs section on New Tab Page?
If so people might want to get more closed tabs from there.</pre>
</blockquote>
<p>On January 11th, 2011, 5:52 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, it is.
But I think we'll have there the same performance problem you experience in the context menu.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">actually as far as I can tell there is a big difference between the context menu and the new tab page with the closed tabs:
The context menu is there to quickly access the last closed tabs, because you might’ve closed one or two tabs accidentaly, because your middle mouse button is kinda broken (true story :-D).
The problem is, that if that context menu has *a lot* of entries, displaying the context menu can take *forever*, which defeats the purpose of the menu.
Also sometimes you accidentaly hove your cursor over that entry and then you need to wait until the context menu is displayed.
The new tab page does not have these problems, at least I did not experience them. Also, you cannot accidentaly click on the closed tab page, and even if you do, it won’t freeze the browser^^</pre>
<br />
<p>- Panagiotis</p>
<br />
<p>On January 7th, 2011, 8:29 p.m., Furkan Üzümcü wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2011, 8:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After a lon rekonq session, you often have closed *a lot* of tabs. If you then
accidentaly closed a tab and you want to open it up, rekonq will freeze, while
the Closed Tabs context menu is loading. This is due to the many entries in
that menu.
Limiting the menu to 10 entries would make the situation better.
This also probably would solve the memory leak, that probably is caused by the
context menu.
If I use rekonq for a long time, and then close a lot of tabs, the RAM usage of
rekonq can go as high as 1.5 GB (yes, Gigabyte ;-))
https://bugs.kde.org/show_bug.cgi?id=240356</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Tested and works!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tabbar.cpp <span style="color: grey">(286d7d4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100315/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>