<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100164/">http://git.reviewboard.kde.org/r/100164/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 24th, 2010, 11:14 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oops... I finally spent a couple of minutes downloading your patch and really testing it. I don't think we can really apply it as this completely breaks rekonq feature of embedding parts. IMHO, this is a no-go.</pre>
</blockquote>
<p>On January 5th, 2011, 9:25 a.m., <b>Jon Ander PeƱalba</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about a settings option to allow the user to select if he prefers to embed the files or to open them in another application?
The other option is to have both in the same dialog. If you look at the BrowserOpenOrSaveQuestion class you can see this: "// TODO askOpenEmbedOrSave". We might be able to implement it ourself.
I would like to have the option to open files in external applications, but I agree that embedding parts is more important so it can't be implemented if they break.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the think Jon is talking about is a completely different feature from the one implemented here (so that this request should be closed).
About Jon's request.. the settings option should be quite easy and fast to implement, while the second one is not "canonical" and IMHO more complicated. </pre>
<br />
<p>- Andrea</p>
<br />
<p>On November 22nd, 2010, 7:31 p.m., Chinmaya Padhi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Chinmaya Padhi.</div>
<p style="color: grey;"><i>Updated 2010-11-22 19:31:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding the feature of Open with Preferred Application and Open With options , while clicked on a file . </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on various files by clicking on them and opening them in the preferred application. It works fine .</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/webpage.cpp <span style="color: grey">(2347b6d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100164/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>