<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100236/">http://git.reviewboard.kde.org/r/100236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 27th, 2010, 9:59 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100236/diff/1/?file=5589#file5589line414" style="color: black; font-weight: bold; text-decoration: underline;">src/urlbar/urlresolver.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void UrlResolver::suggestionsReceived(const QString &text, const ResponseList &suggestions)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">406</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">UrlResolver</span><span class="o">::</span><span class="n">suggestionsReceived</span><span class="p">(</span><span class="k">const</span> <span class="n"><span class="hl">QString</span></span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">text</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">ResponseList</span> <span class="o">&</span><span class="n">suggestions</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">414</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">UrlResolver</span><span class="o">::</span><span class="n">suggestionsReceived</span><span class="p">(</span><span class="k">const</span> <span class="n">ResponseList</span> <span class="o">&</span><span class="n">suggestions</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand the API change here. Why did you remove the string check here?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Suggestions was not displayed when you switch using a webshortcut. For example: "wp:a" != "a"
The goal of this code was to be sure that suggestions correspond to the typed text. I will reintroduce it in an other way if it is really needed.</pre>
<br />
<p>- Lionel</p>
<br />
<p>On December 23rd, 2010, 4:15 p.m., Lionel Chauvin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Lionel Chauvin.</div>
<p style="color: grey;"><i>Updated 2010-12-23 16:15:20</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">update the completion list when the user switch search engine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/opensearch/opensearchmanager.h <span style="color: grey">(df8e536)</span></li>
<li>src/opensearch/opensearchmanager.cpp <span style="color: grey">(4ee1de3)</span></li>
<li>src/opensearch/searchengine.cpp <span style="color: grey">(92b3293)</span></li>
<li>src/urlbar/completionwidget.h <span style="color: grey">(6545b11)</span></li>
<li>src/urlbar/completionwidget.cpp <span style="color: grey">(087a10a)</span></li>
<li>src/urlbar/listitem.h <span style="color: grey">(0d66a12)</span></li>
<li>src/urlbar/listitem.cpp <span style="color: grey">(d82613f)</span></li>
<li>src/urlbar/urlresolver.h <span style="color: grey">(e6ca770)</span></li>
<li>src/urlbar/urlresolver.cpp <span style="color: grey">(864eca0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100236/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>