<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100213/">http://git.reviewboard.kde.org/r/100213/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 20th, 2010, 2:16 p.m., <b>Jon Ander Peñalba</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like this patch. I'll try it when I get home and if no one is against it I'll push it to master.</pre>
</blockquote>
<p>On December 20th, 2010, 6:23 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't have a mouse at all, so that I cannot properly test it: I'll trust Jon's testing. I just recommend to "stress-test" the patch before merging.</pre>
</blockquote>
<p>On December 20th, 2010, 7:40 p.m., <b>Felix Rohrbach</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm using it since tuesday and it works well. The only thing I noticed is that sometimes the url bar shows the wrong url, but as I could reproduce this without this patch I don't think that it's related (it seems to happen if you go back in history while the page is loading - I'll create a bug report if there is no such one yet).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug report is here: https://bugs.kde.org/show_bug.cgi?id=260844 . As I could reproduce the bug without the patch installed I think it's not related to my patch. So could someone please mege the patch into git?</pre>
<br />
<p>- Felix</p>
<br />
<p>On December 20th, 2010, 7:33 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated 2010-12-20 19:33:15</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some mouses have scroll wheels that you can press to the left or to the right side. With this patch you can use them to go through the website history of a tab (like in Opera).
I don't have git access, so if you like this patch, please merge it yourself into master.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles & works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainview.h <span style="color: grey">(1d04d28)</span></li>
<li>src/mainview.cpp <span style="color: grey">(850101e)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(447885d)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(33a0775)</span></li>
<li>src/settings/settings_general.ui <span style="color: grey">(dccf479)</span></li>
<li>src/webview.h <span style="color: grey">(9518b74)</span></li>
<li>src/webview.cpp <span style="color: grey">(aeaf92b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>