<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100064/">http://git.reviewboard.kde.org/r/100064/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2010, 2:19 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry Lionel, again I merged your patch with your suggestion, compiled and tested it. I visited around 30 sites (quite all from the xml/json list and some more) and I really cannot see anything different from before. .
Can you attach here some suggestions/explanations for testing this feature?</pre>
</blockquote>
<p>On December 13th, 2010, 2:32 p.m., <b>Lionel Chauvin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you try a website of the list, it is normal you don't see anything different because they are already added.
You can try this website: http://www.manga-france.fr , the icon at the right of the urlbar should appear. You can verify if the webshortcut is created, if an entry is added in the db_opensearch.json and if the
xml is downloaded.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do as you suggest. Loaded manga-france, seen webshortcut icon, clicked over, chose "gg" shortcut (the google one). nothing complained :(
Then I started searching in the webshortcuts list (the menu in config settings) and I couldn't find it. I now can no more edit/delete it.
Then I understood we are talking about a different feature, based on the same webshortcut. BAD!
IMHO, the best we can do here is providing opensearch suggestions for the engines present in kdebase_runtime. Without letting users add/modify/delete them, but just choose if use them or not.
Last (but not less important), your implementation cannot work at all installing it, as it tries to write on some root-owned dirs.
Very very last, not really related to your merge request: reviewboard sucks. I truly think KDE needs a way "git-integrated" to handle revisions. Reading today all merge requests and reviews I noticed around 90% of them talking of style/space/capital letters/brackets (that are good, but...) and really few of them saying: "it doesn't work/compile/has been right/bad implemented" and so on.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On December 12th, 2010, 8:05 p.m., Lionel Chauvin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Lionel Chauvin.</div>
<p style="color: grey;"><i>Updated 2010-12-12 20:05:44</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Icon at the right of the urlbar that allows to add an opensearch engine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(f0310b4)</span></li>
<li>src/application.cpp <span style="color: grey">(95aa9cf)</span></li>
<li>src/data/CMakeLists.txt <span style="color: grey">(5f49994)</span></li>
<li>src/data/beolingus.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/db_opensearch.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/de2en.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/dictfr.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/facebook.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_techbase.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_userbase.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/voila.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wikia.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wikipedia.xml <span style="color: grey">(4e15208)</span></li>
<li>src/data/wiktionary.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_english.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/youtube.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(c9863f0)</span></li>
<li>src/opensearch/opensearchengine.cpp <span style="color: grey">(9d5e866)</span></li>
<li>src/opensearch/opensearchmanager.h <span style="color: grey">(4f42b4a)</span></li>
<li>src/opensearch/opensearchmanager.cpp <span style="color: grey">(e5afc14)</span></li>
<li>src/opensearch/suggestionparser.cpp <span style="color: grey">(4ed13e1)</span></li>
<li>src/settings/generalwidget.cpp <span style="color: grey">(642813a)</span></li>
<li>src/settings/settingsdialog.cpp <span style="color: grey">(a3b4f97)</span></li>
<li>src/urlbar/listitem.h <span style="color: grey">(f5f1153)</span></li>
<li>src/urlbar/listitem.cpp <span style="color: grey">(f29a0e9)</span></li>
<li>src/urlbar/urlbar.h <span style="color: grey">(67a693c)</span></li>
<li>src/urlbar/urlbar.cpp <span style="color: grey">(1f4a036)</span></li>
<li>src/urlbar/urlresolver.cpp <span style="color: grey">(57d6ca6)</span></li>
<li>src/urlbar/webshortcutwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlbar/webshortcutwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/webtab.h <span style="color: grey">(12f528d)</span></li>
<li>src/webtab.cpp <span style="color: grey">(bac73fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100064/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>