<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100064/">http://git.reviewboard.kde.org/r/100064/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 12th, 2010, 9:29 p.m., <b>Pierre Rossi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As per Benjamin's comment, I think it'd make the review process easier if you left out the xml files for now, especially if we come up with another way of shipping those files with rekonq than checking them in the git repo (and if we do, they could fit in a separate commit with a quicker review I believe).
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure it is a good idea to separate them: it is a matter of consistency with other features.
I loaded all webshortcut's pages, I checked the one that provide an opensearch description file, I added an entry for them in the db_opensearch.json file, I saved the opensearch description file when it provides suggestions.
If you remove an xml file but keep the entry in db_opensearch.json then the user can't obtain suggestions because the icon will not appear. If you remove the xml and the entry in db_opensearch.json then the icon will be displayed, the user can download the xml file, add the entry in db_opensearch.json but a new webshortcut will be added => two webshortcuts for the same engine.</pre>
<br />
<p>- Lionel</p>
<br />
<p>On December 12th, 2010, 8:05 p.m., Lionel Chauvin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Lionel Chauvin.</div>
<p style="color: grey;"><i>Updated 2010-12-12 20:05:44</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Icon at the right of the urlbar that allows to add an opensearch engine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(f0310b4)</span></li>
<li>src/application.cpp <span style="color: grey">(95aa9cf)</span></li>
<li>src/data/CMakeLists.txt <span style="color: grey">(5f49994)</span></li>
<li>src/data/beolingus.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/db_opensearch.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/de2en.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/dictfr.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/facebook.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_techbase.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_userbase.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/voila.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wikia.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wikipedia.xml <span style="color: grey">(4e15208)</span></li>
<li>src/data/wiktionary.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_english.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/youtube.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(c9863f0)</span></li>
<li>src/opensearch/opensearchengine.cpp <span style="color: grey">(9d5e866)</span></li>
<li>src/opensearch/opensearchmanager.h <span style="color: grey">(4f42b4a)</span></li>
<li>src/opensearch/opensearchmanager.cpp <span style="color: grey">(e5afc14)</span></li>
<li>src/opensearch/suggestionparser.cpp <span style="color: grey">(4ed13e1)</span></li>
<li>src/settings/generalwidget.cpp <span style="color: grey">(642813a)</span></li>
<li>src/settings/settingsdialog.cpp <span style="color: grey">(a3b4f97)</span></li>
<li>src/urlbar/listitem.h <span style="color: grey">(f5f1153)</span></li>
<li>src/urlbar/listitem.cpp <span style="color: grey">(f29a0e9)</span></li>
<li>src/urlbar/urlbar.h <span style="color: grey">(67a693c)</span></li>
<li>src/urlbar/urlbar.cpp <span style="color: grey">(1f4a036)</span></li>
<li>src/urlbar/urlresolver.cpp <span style="color: grey">(57d6ca6)</span></li>
<li>src/urlbar/webshortcutwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlbar/webshortcutwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/webtab.h <span style="color: grey">(12f528d)</span></li>
<li>src/webtab.cpp <span style="color: grey">(bac73fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100064/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>