<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100198/">http://git.reviewboard.kde.org/r/100198/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Comments from the rekonq mailing list:
t would be nice to sort the includes by alphabetical order (like for
WebKit).
NetworkAnalyzer::contextMenuEvent() mixes spaces and tabs for the
indentation.
In NetworkAnalyzer::contextMenuEvent(), the parent of the KMenu is
messing things up. QObjects created on the stack should not have parents.
+ KAction *copy;
+ copy = new KAction(KIcon("edit-copy"),i18n("Copy URL"), this);
Could be:
KAction *const copy = new KAction(KIcon("edit-copy"),i18n("Copy URL"),
this);
(Just a suggestion, some knows how much I like "const" :)).
In NetworkAnalyzer::contextMenuEvent(), the connect() misses spaces
after the comas to follow the coding style.
I am not sure how this connection works:
connect( _requestList, SIGNAL(customContextMenuRequested(QPoint)), this,
SLOT(contextMenuEvent(QContextMenuEvent*))) ;
The arguments seem incompatible to me.
by Benjamin Poulain
——————
> I am not sure how this connection works:
> connect( _requestList, SIGNAL(customContextMenuRequested(QPoint)), this,
> SLOT(contextMenuEvent(QContextMenuEvent*))) ;
> The arguments seem incompatible to me.
Yes, code is wrong there and need fixes.
IMHO, the copyURL() method should be renamed as "copyUrl()".
Apart then those, it seems working well.
by Andrea Diamantini
</pre>
<br />
<p>- Panagiotis</p>
<br />
<p>On December 9th, 2010, 2:26 p.m., Furkan Üzümcü wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<p style="color: grey;"><i>Updated 2010-12-09 14:26:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Copy context menu for Network Analyzer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and works cool!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/analyzer/networkanalyzer.h <span style="color: grey">(9e38663)</span></li>
<li>src/analyzer/networkanalyzer.cpp <span style="color: grey">(c5b0883)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100198/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>