<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100064/">http://git.reviewboard.kde.org/r/100064/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, the patch is incredibly huge. And I have a problem with: I failed trying applying it to a master copy branch. Benjamin, did you apply it somewhere or just read code here?
Second, are we sure rekonq is the right place for installing all these xml files?
Third, why are there some french written files and/or with names containing spaces, brackets and so on?</pre>
<br />
<p>- Andrea</p>
<br />
<p>On December 8th, 2010, 8:44 p.m., Lionel Chauvin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Lionel Chauvin.</div>
<p style="color: grey;"><i>Updated 2010-12-08 20:44:23</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Icon at the right of the urlbar that allows to add an opensearch engine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>"a/src/data/recherche_de_vid/303/251os_youtube.xml" <span style="color: grey">(PRE-CREATION)</span></li>
<li>"a/src/data/wikip/303/251dia_(fr).xml" <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(f0310b4)</span></li>
<li>src/application.cpp <span style="color: grey">(95aa9cf)</span></li>
<li>src/data/7digitalcom.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/CMakeLists.txt <span style="color: grey">(5f49994)</span></li>
<li>src/data/beolingus.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/bliptv.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/bugzilla.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/citeseerx.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/cpan_search.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/de-en_beolingus.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/dictfr.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/duck_duck_go.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/ecosia.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/facebook.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/flickr.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/github.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/identica_people_search.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_techbase.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_techbase_(en).xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_userbase.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/kde_userbase_(en).xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/leo_deu-eng.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/leo_deu-fra.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/portail_lexical_-_cnrtl.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/urban_dictionary.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/voila.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wikia.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wikia_(en).xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wikipedia.xml <span style="color: grey">(4e15208)</span></li>
<li>src/data/wiktionary.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wiktionary_(en).xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wolfram_alpha.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_english-french.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_english-italian.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_english-spanish.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_english.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_french-english.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_italian-english.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/wr_spanish-english.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/yippy.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(c9863f0)</span></li>
<li>src/opensearch/opensearchengine.cpp <span style="color: grey">(9d5e866)</span></li>
<li>src/opensearch/opensearchmanager.h <span style="color: grey">(4f42b4a)</span></li>
<li>src/opensearch/opensearchmanager.cpp <span style="color: grey">(e5afc14)</span></li>
<li>src/opensearch/suggestionparser.cpp <span style="color: grey">(4ed13e1)</span></li>
<li>src/settings/generalwidget.cpp <span style="color: grey">(642813a)</span></li>
<li>src/settings/settingsdialog.cpp <span style="color: grey">(a3b4f97)</span></li>
<li>src/urlbar/listitem.h <span style="color: grey">(f5f1153)</span></li>
<li>src/urlbar/listitem.cpp <span style="color: grey">(f29a0e9)</span></li>
<li>src/urlbar/urlbar.h <span style="color: grey">(67a693c)</span></li>
<li>src/urlbar/urlbar.cpp <span style="color: grey">(1f4a036)</span></li>
<li>src/urlbar/urlresolver.cpp <span style="color: grey">(57d6ca6)</span></li>
<li>src/urlbar/webshortcutwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlbar/webshortcutwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/webtab.h <span style="color: grey">(12f528d)</span></li>
<li>src/webtab.cpp <span style="color: grey">(bac73fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100064/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>