<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100167/">http://git.reviewboard.kde.org/r/100167/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can confirm it works well. But I'm not really satisfied with this change. In fact I remember we debated a lot about contextual actions. First 2 considerations:
1) the find action is shown also when pointing an image. IMHO, in that case it has to not be shown.
2) with the "view image in a new tab" we reached the sixth action image related!! IMHO it is a bit too much :)
I have a suggestion about: why don't you change the "actual" view image action to show it in a new tab as default?</pre>
<br />
<p>- Andrea</p>
<br />
<p>On November 24th, 2010, 4:54 p.m., Nikhil Shantanu Marathe wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Nikhil Shantanu Marathe.</div>
<p style="color: grey;"><i>Updated 2010-11-24 16:54:44</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was a Google Code In 2010 task. Context menu improvements are by Furkan Uzumcu <furkanuzumcu@gmail.com>. They include:
* Find... and Print... actions in context menu
* Detect URL like selected text and offer to treat it as a URL and open in new window/tab
* View Image in new Tab</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and works OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.h <span style="color: grey">(33fd202)</span></li>
<li>src/webview.h <span style="color: grey">(9518b74)</span></li>
<li>src/webview.cpp <span style="color: grey">(7664805)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100167/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>