<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100147/">http://git.reviewboard.kde.org/r/100147/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 14th, 2010, 6:53 p.m., <b>Pierre Rossi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100147/diff/1/?file=3578#file3578line326" style="color: black; font-weight: bold; text-decoration: underline;">src/history/historymanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void HistoryManager::loadSettings()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">306</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">historyFilePath</span> <span class="o">=</span> <span class="n">KStandardDirs</span><span class="o">::</span><span class="n">locateLocal</span><span class="p">(</span><span class="s">"appdata"</span> <span class="p">,</span> <span class="s">"history"</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">323</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">historyFilePath</span> <span class="o">=</span> <span class="n">KStandardDirs</span><span class="o">::</span><span class="n">locateLocal</span><span class="p">(</span><span class="s">"appdata"</span> <span class="p">,</span> <span class="s">"history<span class="hl">2</span>"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">couldn't we keep the same history and read the visitCount field only if (ver >= 24) ?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I need to check it out. Let me try it.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On November 14th, 2010, 5:10 p.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated 2010-11-14 17:10:12</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a visit count parameter to the history. This will used expecially in the Awesome UrlBar ordering suggestions code.
It costs us a change in the HISTORY_VERSION and a temporary use of a new history file (called "history2")
So, it needs further testing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/history/historymanager.h <span style="color: grey">(1e03fb1c9dceb6388de0b121b7f46feb255cc3ea)</span></li>
<li>src/history/historymanager.cpp <span style="color: grey">(92f9caeea905f6c0bb21b28c19e4364a62cef0a3)</span></li>
<li>src/history/historymodels.h <span style="color: grey">(d193cf860e25da1b650dd3b37d406e65f1511df0)</span></li>
<li>src/history/historymodels.cpp <span style="color: grey">(793ff7e50dfb2eef97f84480dd5113fb3752f88a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100147/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>