When we removed it, we debated and decided about that. Moreover (sorry to say, I just explained this before) our implementation of the "right" icons does NOT allow using the KLineEdit::setClearButtonShown() method.<br>
Please, revert your commit and in the future ask for a review before committing changes and/or modifications.<br><br><div class="gmail_quote">2010/11/17 Benjamin Poulain <span dir="ltr"><<a href="mailto:benjamin.poulain@nokia.com">benjamin.poulain@nokia.com</a>></span><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">On 11/17/2010 01:23 AM, ext Jon Ander Peņalba wrote:<br>
> 2010/11/16 Rohan Garg <<a href="mailto:rohangarg@ubuntu.com">rohangarg@ubuntu.com</a> <mailto:<a href="mailto:rohangarg@ubuntu.com">rohangarg@ubuntu.com</a>>><br>
<div class="im">><br>
> Oh forgot to mention my idea :<br>
> Display clear button when URL is still loading, but hide it once the<br>
> url was loaded and show the RSS feed & bookmark buttons.<br>
> Regards<br>
> Rohan Garg<br>
><br>
><br>
> I don't think adding that button is a good idea. We already have a lot<br>
> of widgets in the url bar and if we add more it'll look too bloated.<br>
> Lets keep only the essential ones.<br>
<br>
</div>I agree. I see the value of clear button with touch interface (even<br>
then, there sometime clutter the interface), but on desktop I never use<br>
them.<br>
<br>
cheers,<br>
Benjamin<br>
_______________________________________________<br>
rekonq mailing list<br>
<a href="mailto:rekonq@kde.org">rekonq@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/rekonq" target="_blank">https://mail.kde.org/mailman/listinfo/rekonq</a><br>
</blockquote></div><br>