<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100154/">http://git.reviewboard.kde.org/r/100154/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 16th, 2010, 11:50 p.m., <b>Pierre Rossi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have to admit, that's way more readable. :)
I'll test that tomorrow for stuff like "foo" with an url or title in "foofoofoo", but other than that, I think the tests cover all the other crappy cases I can think of (or Andrea could think of). ;)
We probably still need a Qt::escape at some point, mostly for page titles that have stupid characters like '<' and '>', twiki(http://twiki.org/cgi-bin/view/TWiki/WhatIsTWiki) is good at that !
But I agree ideally the urls have no reason to be escaped. I guess we could refine that in another commit</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huh, just built with the patch for testing, and the fact that typing a dot highlights everything totally puts me off ! I have to agree with Benjamin, use of regexps here is going to be trouble.
The Qt::escape() could still probably go away for urls but that'll take a bit of refactoring to distinguish url listitem and title listitem...</pre>
<br />
<p>- Pierre</p>
<br />
<p>On November 16th, 2010, 7:17 p.m., Jon Ander Peñalba wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Jon Ander Peñalba.</div>
<p style="color: grey;"><i>Updated 2010-11-16 19:17:39</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've simplified text highlighting. I think the behaviour hasn't changed, but a second opinion is welcome :)
I've removed the Qt::escape (and updated the test accordingly) because I find it useless, but if it needs to be there for any reason there's no problem in putting it back.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The 'listitem_test' test passes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tests/listitem_test.cpp <span style="color: grey">(fc0b62e)</span></li>
<li>src/urlbar/listitem.cpp <span style="color: grey">(a0462e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100154/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>