<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100126/">http://git.reviewboard.kde.org/r/100126/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2010, 6:03 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100126/diff/1/?file=3065#file3065line125" style="color: black; font-weight: bold; text-decoration: underline;">src/bookmarks/bookmarkowner.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">118</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">openBookmarkFolder</span><span class="p">(</span><span class="k">const</span> <span class="n">KBookmark</span> <span class="o">&</span><span class="n">bookmark</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">98</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">openBookmarkFolder</span><span class="p">(</span><span class="k">const</span> <span class="n">KBookmark<span class="hl">Group</span></span> <span class="o">&</span><span class="n">bookmark</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should probably change here the parameter name to bkGroup or something like that.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point :)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2010, 6:03 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100126/diff/1/?file=3066#file3066line239" style="color: black; font-weight: bold; text-decoration: underline;">src/bookmarks/bookmarkowner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void BookmarkOwner::openBookmarkInNewTab(const KBookmark &bookmark)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">228</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KBookmarkDialog</span> <span class="o">*</span><span class="n">dialog</span> <span class="o">=</span> <span class="n">bookmarkDialog</span><span class="p">(</span><span class="n">m_manager</span><span class="p">,</span> <span class="n"><span class="hl">QApplication</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">activeWindow</span></span><span class="p"><span class="hl">()</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">214</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KBookmarkDialog</span> <span class="o">*</span><span class="n">dialog</span> <span class="o">=</span> <span class="n">bookmarkDialog</span><span class="p">(</span><span class="n">m_manager</span><span class="p">,</span> <span class="mi"><span class="hl">0</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm... letting this without a parent will probably leak mem using it.
The same applies in the other occasions you removed it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I removed the parent because there's a delete at the end of the function that will be called a lot sooner than the activeWindow's destructor.</pre>
<br />
<p>- Jon Ander</p>
<br />
<p>On November 1st, 2010, 4:34 p.m., Jon Ander Peñalba wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Yoann Laissus.</div>
<div>By Jon Ander Peñalba.</div>
<p style="color: grey;"><i>Updated 2010-11-01 16:34:59</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've done some clean-up to the bookmark API.
There are still some things I want to improve, I hope to work on it soon, but I've been busier than expected lately.
This diff is more than one commit, if you want to see each commit look at my personal clone: http://gitorious.org/~Jonan/rekonq/jonans-mainline/commits/bookmark</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/bookmarks/bookmarkowner.h <span style="color: grey">(573e4ee)</span></li>
<li>src/bookmarks/bookmarkowner.cpp <span style="color: grey">(77af9b1)</span></li>
<li>src/bookmarks/bookmarkprovider.cpp <span style="color: grey">(ccdc326)</span></li>
<li>src/bookmarks/bookmarkscontextmenu.h <span style="color: grey">(d669eef)</span></li>
<li>src/bookmarks/bookmarkscontextmenu.cpp <span style="color: grey">(93df6ce)</span></li>
<li>src/bookmarks/bookmarkspanel.h <span style="color: grey">(f042d4c)</span></li>
<li>src/bookmarks/bookmarkspanel.cpp <span style="color: grey">(f732cb2)</span></li>
<li>src/bookmarks/bookmarkstoolbar.cpp <span style="color: grey">(4449d92)</span></li>
<li>src/history/historypanel.h <span style="color: grey">(0a5ae21)</span></li>
<li>src/history/historypanel.cpp <span style="color: grey">(28f7f4e)</span></li>
<li>src/urlpanel.h <span style="color: grey">(722eeae)</span></li>
<li>src/urlpanel.cpp <span style="color: grey">(b3e8b2f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100126/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>