<div class="gmail_quote">On Sun, Apr 19, 2009 at 8:27 AM, Andrea Diamantini <span dir="ltr"><<a href="mailto:adjam7@gmail.com">adjam7@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Saturday 18 April 2009 13:33:49 you wrote:<br>
> > About bookmarks questions, my idea is to refactor rekonq bookmarks system<br>
> > in<br>
> > this way:<br>
> > - create a separate dir for bookmarks tab (like Arora), not exposing ALL<br>
> > bookmarks.<br>
><br>
> Sorry but I don't understand, maybe show us some code proposal, a sort of<br>
> draft implementation or please try to write more about it.<br>
<br>
<br>
</div>You can just take a look at Arora bookmarks menu, with a separate dir<br>
containing all the bookmarks to be stored in the bm tab</blockquote><div><br>OK, I know what you mean. You want bookmarks bar's bookmarks to be shown in bookmarks menu as a separate folder. Wouldn't be easier if you just write what you mean?<br>
</div><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
> > - support KDE bookmarks:/ protocol<br>
> > For me the second should be right alternative to bookmarks sidebar.<br>
><br>
> this is nontrivial work, it would depend on major refactoring of the tabs<br>
> subsystem (which is planned because mainview is a "maintainability<br>
> nightmare"<br>
<br>
</div>Support for bookmarks:/ protocol (and for all other kioslaves) will come with<br>
next version, porting rekonq to WebkitKDE.</blockquote><div> <br>What porting? And what WebKitKDE? Do you mean webkit KPart? I hope this is nontrivial task and If we want to use KPart we need rewrite lots of code. I was thinking about this, but until I take a look at the code I can't tell how difficult it would be and in what shape it is (as far as I see in Konqueror it's in terrible state, but isn't maybe because of that the KDE 4.2 is compiled against Qt 4.4 AFAIK). Generally I think this is a good idea to give it some thought and it would benefit the community, but as I said, we need to investigate this further and if we want this, we need to start now, there is no sense of doing refactoring and then delete the code and write again. :F<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Can you pls write some about this mainview "maintainability nightmare"?</blockquote><div><br>Have you seen the MainView code? Have you seen changes I started to make? How can I explain to you that the code the class is bloated? Try to make UML diagram of the class hierarchy. <br>
It need to be divided in to classes, refactored to DRY to achive bette encapsulation and maintanability, so it would be easier to test and debug.<br>If you don't know what I'm talking about than there is now way I could eplain it to you, sorry :(<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="h5"><br>
> > About download class... I'm going to review again your code ;) Perhaps I<br>
> > pulled some half works, really cannot think some other...<br>
> ><br>
> > rekonq isn't (and has not) a download manager. It just can (obviously)<br>
> > start<br>
> > file downloading. And creating a new instance of download class is (for<br>
> > me) the<br>
> > right way of doing so.<br>
><br>
> This is not so simple. You start the download and what?<br>
> When you close the app it still runs in the background (because of<br>
> downloads) and when you start it again it crashes without proper handling<br>
> (which I solved by some nontrivial debugging and global fixes). And above<br>
> the all, modular code is easier to use, maintain, test and debug.<br>
> You can't just create object and forget about it, this isn't Java. You have<br>
> to track the ownership of the object and delete all objects that are owned<br>
> by your classes or you'll introduce another memory leak. And to do this you<br>
> have to track(manage) your download objects and for this you need download<br>
> manager (it's a container).<br>
> And what if user cancels the download in KDE notification? You still have<br>
> to delete the object.<br>
> And what if there was error during download? etc...<br>
><br>
> From that KIO::job we can link to (and just do it) to KDE notification<br>
><br>
> > system,<br>
> > to kget or to every other download manager supporting KDE technologies.<br>
> > It's fast, simple and safe. So (again), what's better?<br>
><br>
> IMHO always the best solution is to follow the convention ("Convention over<br>
> configuration" principle) and established convention is to "handle<br>
> download" (that's what user cares of - "I want to download it and I don't<br>
> care how it is implemented")<br>
> Most browsers ask user what to do with the download (open/save as...), and<br>
> then opens stuff for them (if they wanted).<br>
> And this is great because I can install application (openSUSE 1-click<br>
> feature) just by clicking on the link (this is something that firefox can't<br>
> do because it doesn't integrate with the environment) and this is something<br>
> that download manager provides.<br>
<br>
</div></div>This is definitely true, mainline/master download system is bugged, I'm going<br>
to fix it with your suggestions.</blockquote><div> <br><br>Those are not suggestions, but facts, issues that had been alredy adressed by avaddon and me, so no need for fix (other than bugs we missed or introduced by accident)<br>
<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
> So rekonq have to have some sort of downloads manager.<br>
> To stay lightweight we can make simple icon/button in (for e.g lower-right<br>
> corner) witch would appear only when there are downloads (completed or<br>
> active) along with number of downloads (active/completed).<br>
> If clicked it can show thin downloads bar on the bottom (sort of like<br>
> firefox plugin), but I'm not entirely convinced with this idea since we<br>
> want to integrate with KDE notifications system.<br>
> Alternatively we can try to call KDE notification by DBus to show itself.<br>
><br>
><br>
> And to add something form myself, we need to write a lots of unit tests, to<br>
> test automatically at least 50% of the code. And to add regression tests<br>
> (especially for issues, to have a rule: "new bug fix committed = new<br>
> regression test committed", this would be off course ideal situation but if<br>
> we'll follow this mostly it will make our lives easier). I've started to<br>
> add tests for things I work with, but we would benefit from more unit tests<br>
> to have sort of "safety net" while doing changes. It's part of so called<br>
> "defensive programming".<br>
><br>
> Regards<br>
<br>
</div>PS: please, write directly to rekonq ml, no need to write me and then CC<br>
there.</blockquote><div><br>This is default GMail behaviour and usualy I'm to lazy to change it... ;) <br></div></div><br>