[rekonq] Review Request 110224: Adds the feature to close tabs to the right/left of that tab

[mayank jha]

> On July 30, 2013, 4:07 p.m., Bernd Oliver Sünderhauf wrote:
> > Quick review, but not yet tested:
> > 
> > The naming of closeOtherLeftTabs() and closeOtherRightTabs() makes no sense and is a bit irritating.
> > It's not the "other right tabs" - it's the tabs to the right.
> > closeLeftTabs() and closeRightTabs() to me seems okay and would nicely match with closeOtherTabs().
> > 
> > As proposed on https://bugs.kde.org/show_bug.cgi?id=248830, we should IMHO move the three menu items to a submenu "Close multiple tabs".

Firefox 26 now supports this feature, I think rekonq too should be supporting this, should I rebase this on the current master ?


- mayank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110224/#review36821
-----------------------------------------------------------


On April 27, 2013, 9:20 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110224/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 9:20 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Bugs: 248830
>     /show_bug.cgi?id=248830
> 
> 
> Repository: rekonq
> 
> 
> Description
> -------
> 
> When dealing with a large number of tabs it would be great to have an option on the tab right-click menu to close tabs to the right of that tab or to the left of that tab.
> 
> 
> Diffs
> -----
> 
>   src/tabwindow/tabbar.h 73b5802 
>   src/tabwindow/tabbar.cpp eb062bf 
>   src/tabwindow/tabwidget.h 02ac9ac 
>   src/tabwindow/tabwidget.cpp 1234175 
> 
> Diff: https://git.reviewboard.kde.org/r/110224/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and tests successfully!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20140315/634a35ed/attachment.html>