[rekonq] Review Request 115223: Substituting keyPressEvent with keyReleaseEvent to fix bug # 321967

Commit Hook null at kde.org
Thu Jan 23 15:01:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115223/#review48130
-----------------------------------------------------------


This review has been submitted with commit 5f13021dbc94c13336deb1d2a4849908c9db231e by Andrea Diamantini on behalf of Mikhail Krutov to branch master.

- Commit Hook


On Jan. 22, 2014, 1:15 p.m., Mikhail Krutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115223/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 1:15 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Bugs: 321967
>     /show_bug.cgi?id=321967
> 
> 
> Repository: rekonq
> 
> 
> Description
> -------
> 
> text() gets updated only after keyPressEvent thus URL might be trimmed of last character or charaters in case of user is fast-typer.
> Replacing event with keyReleaseEvent, however, fixes the problem: text() is updated before it happens.
> https://bugs.kde.org/show_bug.cgi?id=321967
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.h 67c2a9c 
>   src/urlbar/urlbar.cpp 2dca0ac 
> 
> Diff: https://git.reviewboard.kde.org/r/115223/diff/
> 
> 
> Testing
> -------
> 
> Browsing with patched browser for some time.
> 
> 
> Thanks,
> 
> Mikhail Krutov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20140123/972441a5/attachment.html>


More information about the rekonq mailing list