[rekonq] Review Request 114804: Fix inconsistent dll linkage

Andrea Diamantini adjam7 at gmail.com
Thu Jan 2 09:35:17 UTC 2014



> On Jan. 2, 2014, 9:34 a.m., Andrea Diamantini wrote:
> > Ship It!

Many thanks!
Just let me know if I have to push myself it.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114804/#review46598
-----------------------------------------------------------


On Jan. 1, 2014, 10:35 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114804/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2014, 10:35 p.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Repository: rekonq
> 
> 
> Description
> -------
> 
> Those sources aren't being used for a shared lib, so they must not export.
> 
> 
> Diffs
> -----
> 
>   src/nepomuk/utils/nepomukutils_export.h 718bd7c 
>   src/nepomuk/utils/resourcemodel.h 526c7ac 
>   src/nepomuk/utils/simpleresourcemodel.h 2f48d93 
> 
> Diff: https://git.reviewboard.kde.org/r/114804/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20140102/f8bb4a88/attachment.html>


More information about the rekonq mailing list