[rekonq] Review Request 109613: Save your browsing sessions with rekonq

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109613/#review30158
-----------------------------------------------------------


Hi Mayank,
and sorry for the very late review. I anyway started in the morning checking your code and fixing things, so that I reached a nice level, at least in my opinion. Please, review the "SessionSaving" branch in rekonq git. It contains your desired feature, starting from your code and adding some nice extra features:
- session management dialog (load / save / rename / delete sessions)
- hided file user sessions management (stored in rekonq "secrets")
- ability to start with a saved session
- clean up all other things while loading a session

- Andrea Diamantini


On March 20, 2013, 4:54 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109613/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 4:54 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> A patch which allows you to save and later reload your important browsing sessions!
> 
> 
> Diffs
> -----
> 
>   src/history/historymanager.h a618c67 
>   src/history/historymanager.cpp 2fab9cf 
>   src/sessionmanager.h 6d6bef2 
>   src/sessionmanager.cpp 8c78172 
>   src/webwindow/rekonqui.rc 90c5c19 
>   src/webwindow/webwindow.h b2e0f5a 
>   src/webwindow/webwindow.cpp 1225fb0 
> 
> Diff: http://git.reviewboard.kde.org/r/109613/diff/
> 
> 
> Testing
> -------
> 
> works fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130330/50f948a2/attachment.html>