[rekonq] Review Request 111521: Adding domain-specific hiding support to the adblocker

[Andrea Diamantini]

> On July 29, 2013, 8:42 a.m., Andrea Diamantini wrote:
> > Ship It!

Again, please let me know if you need help merging this.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111521/#review36713
-----------------------------------------------------------


On July 15, 2013, 2:10 p.m., Paul Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111521/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 2:10 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Adding domain-specific hiding support to the adblocker.
> 
> The domain-specific rules are stored in a QMultiHash, where the key is the domain and the values are the rules for the specified domain. This causes redundancy, because on rule can be applied to more than one domain, but has a really fast look-up time. The code for the generic hiding has not changed and is just relocated.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c749a69 
>   src/adblock/adblockelementhiding.h PRE-CREATION 
>   src/adblock/adblockelementhiding.cpp PRE-CREATION 
>   src/adblock/adblockmanager.h 3d329ad 
>   src/adblock/adblockmanager.cpp 51000a3 
> 
> Diff: http://git.reviewboard.kde.org/r/111521/diff/
> 
> 
> Testing
> -------
> 
> - it hides things
> - it is reasonably fast (generic hiding takes with my configuration 300-500ms, the domain-specific hiding only takes 30-70µs)
> 
> 
> Thanks,
> 
> Paul Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130729/4a2f0a99/attachment.html>