[rekonq] Review Request: Rekonq Migration to Nepomuk2

[Andrea Diamantini]

> On Jan. 7, 2013, 10:23 p.m., Andrea Diamantini wrote:
> > /SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp: In member function ‘void Nepomuk2::NewResourceDialog::newResourceSlot()’:
> > /SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:94:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
> > /SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:100:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
> > /SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:106:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
> > /SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:112:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
> > /SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:118:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
> > make[2]: *** [src/CMakeFiles/kdeinit_rekonq.dir/urlbar/newresourcedialog.cpp.o] Error 1
> > make[1]: *** [src/CMakeFiles/kdeinit_rekonq.dir/all] Error 2
> > make: *** [all] Error 2
> >
> 
> David Narváez wrote:
>     My bad, the code requires NepomukCore >= 4.10. If that imposes too much of a constrain, then I could patch it to require either Nepomuk or NepomukCore >= 4.10, let me know what's best.

If you are requiring to depends on the unreleased nepomukcore 4.10, I vote for reverting this and stay with nepomuk1 until kde 4.10 has been released.
After that, move to nepomuk2 and let it compile just if >= 4.10 is available.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108152/#review24954
-----------------------------------------------------------


On Jan. 4, 2013, 4:56 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108152/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 4:56 a.m.)
> 
> 
> Review request for rekonq and Vishesh Handa.
> 
> 
> Description
> -------
> 
> As we move forward with Rekonq 2  I think it is a good opportunity to jump to Nepomuk2. I had to copy some models that are not (yet?) available in Nepomuk2 and I'm including Vishesh who knows best about the migration process.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 11015c5 
>   config-nepomuk.h.cmake fe7364f 
>   src/CMakeLists.txt 143f9dc 
>   src/bookmarks/bookmarkowner.h 6a18c23 
>   src/bookmarks/bookmarkowner.cpp ba2d8f6 
>   src/bookmarks/bookmarkscontextmenu.cpp 69cde75 
>   src/nepomuk/utils/nepomukutils_export.h PRE-CREATION 
>   src/nepomuk/utils/resourcemodel.h PRE-CREATION 
>   src/nepomuk/utils/resourcemodel.cpp PRE-CREATION 
>   src/nepomuk/utils/simpleresourcemodel.h PRE-CREATION 
>   src/nepomuk/utils/simpleresourcemodel.cpp PRE-CREATION 
>   src/urlbar/bookmarkwidget.h 39f6fbd 
>   src/urlbar/bookmarkwidget.cpp e266a07 
>   src/urlbar/newresourcedialog.h 651c631 
>   src/urlbar/newresourcedialog.cpp 39cffc3 
>   src/urlbar/resourcelinkdialog.h e628aa1 
>   src/urlbar/resourcelinkdialog.cpp 799171f 
> 
> Diff: http://git.reviewboard.kde.org/r/108152/diff/
> 
> 
> Testing
> -------
> 
> 1. Tagged a bookmark using Rekonq 2 before this patch
> 2. Recompiled and reinstalled Rekonq 2 with this patch
> 3. Confirmed the old bookmark is kept, with the correct tags
> 4. Added a new bookmark and tagged it
> 5. Checked that both tags are available in the tag dialog elsewhere in my KDE Desktop
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130108/6bbabe2f/attachment.html>