[rekonq] Review Request 112289: Set the Base URL of Error Pages

Andrea Diamantini adjam7 at gmail.com
Mon Aug 26 18:28:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112289/#review38688
-----------------------------------------------------------

Ship it!


Ship It!

- Andrea Diamantini


On Aug. 26, 2013, 1:17 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112289/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 1:17 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Otherwise, all error pages show about:blank in the URL which makes it complicated for the user to know what page went wrong.
> 
> 
> Diffs
> -----
> 
>   src/webtab/webpage.cpp 8f45475 
> 
> Diff: http://git.reviewboard.kde.org/r/112289/diff/
> 
> 
> Testing
> -------
> 
> 1. Disconnect from the internet
> 2. Load a web page
> 
> Before this patch, a Network Error page would show up, but the URL box would be set to about:blank. After this patch the URL box will display the correct URL.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130826/68484e1c/attachment.html>


More information about the rekonq mailing list