[rekonq] Review Request 109808: adds shortcuts for clone, pin and detach in the tabbar.

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109808/#review30597
-----------------------------------------------------------


Ok, you fixed first step.
Now:
1) how did you choose new shortcuts? Are them used somewhere else? Why didn't you choose to just add them to the tabwidget (listing them in the shortcut configuration dialog) and then leaving nothing as default shortcut?
2) what about e.g. the code in tabbar::contextMenu slot? If you implement such actions in tabwidget you should check all rekonq code to call them when used.

- Andrea Diamantini


On April 2, 2013, 8:36 a.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109808/
> -----------------------------------------------------------
> 
> (Updated April 2, 2013, 8:36 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Just additions to the action set in tabwidget.cpp!
> 
> 
> Diffs
> -----
> 
>   src/tabwindow/tabwidget.cpp a7b4f2b 
> 
> Diff: http://git.reviewboard.kde.org/r/109808/diff/
> 
> 
> Testing
> -------
> 
> tested and runs well! Just icons for pintab and clonetab, cant find it!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130407/04eeac3a/attachment.html>