[rekonq] Review Request: Integrated Spell checking for Rekonq

[Andrea Diamantini]

> On Sept. 13, 2012, 9:10 p.m., Andrea Diamantini wrote:
> > src/webview.cpp, line 513
> > <http://git.reviewboard.kde.org/r/106417/diff/2/?file=85196#file85196line513>
> >
> >     I think you forget to remove this from here. Or is this a desired feature?
> 
> Lindsay Mathieson wrote:
>     A desired feature, its not a config option, rather it invokes a standard floating spell check dialog on the current or selected text.

Yeah! Now I see it! Sorry for the silly issue about :)


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106417/#review18945
-----------------------------------------------------------


On Sept. 13, 2012, 11:44 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106417/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2012, 11:44 a.m.)
> 
> 
> Review request for rekonq, Andrea Diamantini and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Adds integrated spell checking to rekonq.
> 
> - inline spell highlighter. This requires WebKit 2.3 to be present and loaded to work. But rekonq will still run without it. Use:
>   export LD_LIBRARY_PATH=${WEBKITDIR}/WebKitBuild/Release/lib
> To use the WebKit 2.3 libs
> 
> - Addition of a suggested replacement word list to the context menu, for the word right clicked on
> 
> - A standard modeless spell check dialog that works on the current editable text (or selection). Heavily cribbed from Dawit's work on kdewebkitpart.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c794539 
>   src/kspellplugin.h PRE-CREATION 
>   src/kspellplugin.cpp PRE-CREATION 
>   src/qwebkitplatformplugin.h PRE-CREATION 
>   src/rekonq.kcfg 1fb3c1c 
>   src/settings/settings_advanced.ui 9457ca2 
>   src/webview.h 0141925 
>   src/webview.cpp 7272e2c 
> 
> Diff: http://git.reviewboard.kde.org/r/106417/diff/
> 
> 
> Testing
> -------
> 
> Tested with WebKit 2.3 trunk against a variety of websites. Forums such as slashdot etc to get a wide variety of text postings.
> 
> 
> Screenshots
> -----------
> 
> Inline spell highlight
>   http://git.reviewboard.kde.org/r/106417/s/725/
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120917/8e5bd1fa/attachment.html>