[rekonq] Review Request: Activities support for Rekonq

Ivan Čukić ivan.cukic at kde.org
Thu Oct 18 20:48:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106912/
-----------------------------------------------------------

(Updated Oct. 18, 2012, 8:48 p.m.)


Review request for rekonq and Andrea Diamantini.


Changes
-------

I first wanted to make it so that when private mode is enabled, that it should report a blank url to kamd (aka ignore event).

But, I realised that a view can be either private or not (am I right?) so that there is no point in instantiating ResourceInstance object for a private one at all.


Description
-------

Rekonq reports the open/close document events to activity manager daemon.

By knowing which window contains which documents and which one is in focus, we can do the following:

- collect the statistics about visited pages. Further, this provides a score for each document visited, that depends on the number of times it was open, the time the user spent on that location, and the time passed since the last visit.
- availability of a global/workspace applet that allows sharing the current document via e-mail, social networks; bookmarking and rating the link, or connecting it to the current activity. (advantage of this is a unified UI for sharing/rating/linking that works with any application)
- jump-lists (not impl. yet in plasma) to list top rated documents on a launcher icon or in the task manager applet
- krunner can sort the documents based on the score
- more things that I haven't thought of yet

There is no need to *use* ativities to have these benefits. Activities just serve as manual data clustering to provide more useful scores compared to the one-activity approach.


Diffs (updated)
-----

  CMakeLists.txt 030f0fb 
  src/CMakeLists.txt 6c27376 
  src/mainview.h 89ee36e 
  src/mainview.cpp b71a81e 

Diff: http://git.reviewboard.kde.org/r/106912/diff/


Testing
-------

The event reporting was watched in two ways:
- by using the SLC applet (planned to be included in 4.10, currently plasma-mobile) - when rekonq opens a url, the icons light-up and when clicking on an icon, it show whether it reports the document properly
- by using sqlite3 to browse the .kde/share/apps/activitymanager/resources/database - 'select * from nuao_DesktopEvent;'

The tests consisted of using rekonq in two modes - the single-window and multiple-window mode. They consisted of switching between different webpages back-and-forth.


Thanks,

Ivan Čukić

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20121018/9ab429d0/attachment.html>


More information about the rekonq mailing list