[rekonq] Review Request: Provide an mpris2 interface for rekonq to control html5 media elements

Anton Kreuzkamp akreuzkamp at web.de
Sat May 26 08:18:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105059/
-----------------------------------------------------------

Review request for rekonq.


Description
-------

This patch addes a mpris2-compliant dbus-interface to rekonq that allows controling html5-video and -audio elements from e.g. the nowplaying-plasmoid.
This is espacially useful together with youtube's html5-player and the plasmoid PlayControl (which allows to assign global shortcuts to mediaplayer-actions (so you can pause all mediaplayers with the same mediacontrol-keys))
With this patch rekonq aggregates all opened media elements and provides one interface to dbus (providing one interface per media element is not possible with mpris) that contains the data of
and sends commands recieved via dbus to the last active mediaplayer (that was last loaded or changed its playback-status most recently).
The communication to the media element happens via javascript.


Diffs
-----

  src/CMakeLists.txt 1180ad0 
  src/application.h 36114ae 
  src/application.cpp ef6c208 
  src/dbus/mpris2/Mpris2DBusHandler.h PRE-CREATION 
  src/dbus/mpris2/Mpris2DBusHandler.cpp PRE-CREATION 
  src/dbus/mpris2/org.mpris.MediaPlayer2.Player.xml PRE-CREATION 
  src/dbus/mpris2/org.mpris.MediaPlayer2.root.xml PRE-CREATION 
  src/webpage.h abc9f64 
  src/webpage.cpp ce1151d 

Diff: http://git.reviewboard.kde.org/r/105059/diff/


Testing
-------

Comprehensive tests with different html5 mediaplayers (audio and video) and different mpris-controllers. No problems anymore.


Thanks,

Anton Kreuzkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120526/8055c4e0/attachment.html>


More information about the rekonq mailing list