[rekonq] Review Request: Only Update URL Actions from MainView::webViewUrlChanged if the Sender is the Current Tab

[David Narváez]

> On June 9, 2012, 10:50 p.m., Andrea Diamantini wrote:
> > src/mainview.cpp, line 644
> > <http://git.reviewboard.kde.org/r/105184/diff/1/?file=66777#file66777line644>
> >
> >     Just to get rid of another rApp... call, isn't the same concept doing a check like
> >     "index == currentIndex()" ?

I think it's not, you'd also need to check if it is in the same window. That is, the question you need to ask at this point is "is this tab the current tab in the current view in the main window?" otherwise the updateHistoryActions slot will operate on the wrong tab.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105184/#review14562
-----------------------------------------------------------


On June 8, 2012, 12:27 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105184/
> -----------------------------------------------------------
> 
> (Updated June 8, 2012, 12:27 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> This makes sense conceptually, and in practice fixes a bug that has crashed rekonq in my end for about a week yet I'm unclear about how did I get my session to be in this state - which is basically more than one window with at least one of them without tabs.
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp a9bc540 
> 
> Diff: http://git.reviewboard.kde.org/r/105184/diff/
> 
> 
> Testing
> -------
> 
> Hard to test. Should you be able to create a session file with one window without tabs and restore rekonq from that, if the URL of another window (obviously with tabs) changes, the MainView::webViewUrlChanged slot will crash rekonq.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120609/f18f0eb4/attachment.html>