[rekonq] Review Request: Change webTab Variable Name to tabToStop

Pierre Rossi pierre.rossi at gmail.com
Fri Sep 2 15:49:07 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102521/#review6243
-----------------------------------------------------------

Ship it!


- Pierre


On Sept. 2, 2011, 12:08 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102521/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2011, 12:08 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Just for a matter of code clarity, I'd like to propose this patch to change the name of the variable in webStop slot to avoid name collision with the webTab method in the same MainView class.
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp ef4cfa7 
> 
> Diff: http://git.reviewboard.kde.org/r/102521/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110902/4f4ec1bf/attachment.html>


More information about the rekonq mailing list