[rekonq] Re: Review Request: Adds an option in configure dialog to disable the feature of saving password and login info in KDE wallet

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101317/#review3251
-----------------------------------------------------------



src/webtab.cpp
<http://git.reviewboard.kde.org/r/101317/#comment2737>

    This check is less heavy than the wallet blacklist (1 bool vs 1 string list). Can we anticipate it to speed up things?


- Andrea


On May 8, 2011, 9:44 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101317/
> -----------------------------------------------------------
> 
> (Updated May 8, 2011, 9:44 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch adds an option in the 'Configure Rekonq...' dialog in the General tab to 'use the KDE wallet to store login information'. This is enabled by default, but now can be turned off, so that the 'store password for ...?' prompt does not appear.
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg dba770b 
>   src/settings/settings_general.ui 0b27dab 
>   src/webtab.cpp 0994017 
> 
> Diff: http://git.reviewboard.kde.org/r/101317/diff
> 
> 
> Testing
> -------
> 
> Testing done. Works properly.
> 
> 
> Screenshots
> -----------
> 
> The 'Configure Rekonq...' dialog
>   http://git.reviewboard.kde.org/r/101317/s/160/
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110510/9b76ea80/attachment.htm