[rekonq] Re: Review Request: New: Subscript of favorite page "web snaps" (as seen on new tab page) changed from "www.xyz.org" to "N - www.xyz.org" for the N-th favorite page.

[Thomas Murach]

> On May 6, 2011, 3:36 p.m., Andrea Diamantini wrote:
> > Sounds good. Should I commit for you?

Yes, please. 
Thanks a lot!


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101297/#review3166
-----------------------------------------------------------


On May 5, 2011, 10:40 p.m., Thomas Murach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101297/
> -----------------------------------------------------------
> 
> (Updated May 5, 2011, 10:40 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Adding ergonomics feature: Subscript of favorite page "web snaps" (as seen on new tab page) changed from "www.xyz.org" to "N - www.xyz.org" for the N-th favorite page.
> I chose not to create a variable containing this modified string but just pass the "sum" of strings as it's never again needed.
> This feature makes it easier to choose which shortcut you have to press for loading your N-th favorite page via "Ctrl + N"
> 
> 
> Diffs
> -----
> 
>   src/newtabpage.cpp a598066 
> 
> Diff: http://git.reviewboard.kde.org/r/101297/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110506/538aae19/attachment.htm