[rekonq] Re: Review Request: Add favorite with 2 clicks in the bookmark icon

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101945/#review4724
-----------------------------------------------------------

Ship it!


Yeah! that's a really cool addition I think. Small usability details we might need to test and see over time: does the favorite have to be bookmarked by default ? (I know it only takes one click to undo, but it also only takes one click to do...)
As an evolution for the right hand side icons, maybe we could have custom context menus for them, or at least add some custom actions to the lineedit's context menu.


src/urlbar/favoritewidget.h
<http://git.reviewboard.kde.org/r/101945/#comment4136>

    watch those leading white spaces a bit everywhere !



src/urlbar/urlbar.cpp
<http://git.reviewboard.kde.org/r/101945/#comment4140>

    Side note/question: could we get several different logging channels in rekonq ? I feel it's a nice functionality of kDebug that we could take better advantage of.



src/urlbar/urlbar.cpp
<http://git.reviewboard.kde.org/r/101945/#comment4139>

    I know this is not necessarily related, but how about we put asserts in places like these ?



src/urlbar/urlbar.cpp
<http://git.reviewboard.kde.org/r/101945/#comment4138>

    I think the commented lines could safely go away ! ;)


- Pierre


On July 13, 2011, 4:37 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101945/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 4:37 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Provide a "click" mechanism to manage favorites
>     
> With this commit, you can add a favorite by clicking 2 times in the bookmark icon.
> If an URL is a favorite, the favorite icon appears and then you can manage it from there...
> 
> Pushed on remote branch: AddFavoriteWithAClick
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f623adf 
>   src/urlbar/favoritewidget.h PRE-CREATION 
>   src/urlbar/favoritewidget.cpp PRE-CREATION 
>   src/urlbar/urlbar.h 9ed89da 
>   src/urlbar/urlbar.cpp 078dc6a 
> 
> Diff: http://git.reviewboard.kde.org/r/101945/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110716/b39c07cf/attachment.htm