[rekonq] Re: Review Request: This is JuniorJob about doing better Tab Previews

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101848/#review4419
-----------------------------------------------------------


What Fritz_van_tom said, oh wait no I have a few additional comments.  


src/tabpreviewpopup.cpp
<http://git.reviewboard.kde.org/r/101848/#comment3721>

    same as Johannes, use initializations.
    Besides, I believe you don't need this widget, you could just set the layout directly on 'this', or am I missing something ?



src/tabpreviewpopup.cpp
<http://git.reviewboard.kde.org/r/101848/#comment3719>

    Careful with magic numbers ! ;)
    
    I think in the case of someone having their screen in "portrait mode", this aspect ratio wouldn't work at all by the way.
    
    I'd base that either on the window geometry or maybe the current screen's geometry if I were you. See:
    http://doc.qt.nokia.com/latest/qdesktopwidget.html#availableGeometry
    http://doc.qt.nokia.com/latest/qdesktopwidget.html#screenNumber



src/tabpreviewpopup.cpp
<http://git.reviewboard.kde.org/r/101848/#comment3720>

    the mask could be set once and for all as soon as the geometry is set. I don't think this belongs in the paintEvent.


And of course fixing the things Johannes mentioned already, which I hereby +1 ! :P
I guess it should be pretty good after that !

Note to self: really good thing those junior jobs, we should probably try to come up with more. Thanks Wyuka for coming up with this ! :)

- Pierre


On July 4, 2011, 3:06 p.m., Vyacheslav Blinov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101848/
> -----------------------------------------------------------
> 
> (Updated July 4, 2011, 3:06 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Improvements:
> 
> * title of the page is removed since it is visible on a tab.
> * widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame
> * widget has rouned corners in all the styles
> * url of the page is elided
> * with compositing tab previews will be shown semitransparent with 25% alpha by default, witch can be setted to be optional later
> * code of tab preview is now separated from tab bar so it is more explicit
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt db9506a 
>   src/tabbar.h c1b0ba5 
>   src/tabbar.cpp dee49ea 
>   src/tabpreviewpopup.h PRE-CREATION 
>   src/tabpreviewpopup.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101848/diff
> 
> 
> Testing
> -------
> 
> Tested with different styles: it still looks ok, without compositing transparency didn't works
> 
> 
> Screenshots
> -----------
> 
> sample of tab preview
>   http://git.reviewboard.kde.org/r/101848/s/193/
> 
> 
> Thanks,
> 
> Vyacheslav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110705/fc4c916c/attachment.htm