[rekonq] Re: Review Request: Changes to the context menu

[Andrea Diamantini]

> On Jan. 21, 2011, 12:19 a.m., Andrea Diamantini wrote:
> > That's not exactly what I suggested you. Remove the m_developersMenu variable from the class definition and reload the tools menu every time, so that if developer tools are activated you add the developers menu. If not you don't create it at all.
> 
> Felix Rohrbach wrote:
>     I would have thought that this is too slow (you can feel the difference - compare the time it needs to show the first and the second time you open the menu with this patch), but of course I can change it.
> 
> Andrea Diamantini wrote:
>     You are right :(
>     In this case, my idea does not fit. What about reproposing the previous version (diff 3) and merging it? I guess we are not gaining what I supposed with this...
> 
> Felix Rohrbach wrote:
>     I would prefer the last version (4), so that the menu is created the first time the user uses it. I think a delay is ok if it's just the first time (like with dialogs) and it might save us some startup time. Additionally, I don't like version 3 because changing the visibility with aboutToShow() is much cleaner then using a settingsChanged() slot, so if you want to create the menu at startup (the way it is now) I would change at least this.

ok.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100374/#review1010
-----------------------------------------------------------


On Jan. 20, 2011, 4:50 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100374/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2011, 4:50 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch contains the changes to the context menu which we decided in our meeting:
> 
> 1. Hide new tab entry if it is not necessary.
> 2. Print and Search action: I removed the print action. The search action is now in the "search with" submenu if some text is selected.
> 3. Hide the development menu entries and add an option to show them.
> 
> Clone: git://anongit.kde.org/clones/rekonq/felixr/rekonq
> Branch: meetingMenuChanges
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 02cd723 
>   src/mainwindow.cpp 59fff83 
> 
> Diff: http://git.reviewboard.kde.org/r/100374/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110122/a8739799/attachment.htm