[rekonq] Review Request: Code improvement to find the tab under the cursor while showing tab preview

Furkan Üzümcü furkanuzumcu at gmail.com
Sat Jan 8 22:25:07 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100324/
-----------------------------------------------------------

Review request for rekonq.


Summary
-------

When showing tab preview Rekonq uses a while loop to find the tab under the cursor. I think that isn't a really good way of doing it. As I'm not a really good developer my thought would be wrong, but I think using tabAt(const QPoint &position) would be better.


Diffs
-----

  src/tabbar.cpp 5712497 

Diff: http://git.reviewboard.kde.org/r/100324/diff


Testing
-------

* Tested and works.


Thanks,

Furkan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110108/caac5abd/attachment-0001.htm 


More information about the rekonq mailing list