[rekonq] Re: Review Request: GCI Task: Fix the “Open Folder in Tabs” feature

Benjamin Poulain ikipou at gmail.com
Sat Jan 8 00:37:23 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100318/#review769
-----------------------------------------------------------

Ship it!



src/bookmarks/bookmarkowner.cpp
<http://git.reviewboard.kde.org/r/100318/#comment583>

    Q_ASSERT(bookmark.isGroup());
    
    Not toGroup() :)


Fix the assert and it is good.

- Benjamin


On 2011-01-07 23:34:49, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100318/
> -----------------------------------------------------------
> 
> (Updated 2011-01-07 23:34:49)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Fixed the "Open Folder in Tabs" feature.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkowner.h 4d37719 
>   src/bookmarks/bookmarkowner.cpp c684897 
> 
> Diff: http://git.reviewboard.kde.org/r/100318/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110107/666041eb/attachment.htm 


More information about the rekonq mailing list