[rekonq] Fwd: Re: Re: Reverting a619d aka Highlight inactive tab if title changes

[Rohan Garg]

Weird....
I've reverted the commit in a local branch and everything works, but if I
switch to master, I start getting artifacts, I would say this particular
patch needs more testing.

On 16 Feb 2011 03:54, "Andrea Diamantini" <adjam7 at gmail.com> wrote:
> On Tuesday 15 February 2011 21:18:05 Rohan Garg wrote:
>> Um i mean this [1]
>> [1] http://wstaw.org/m/2011/02/15/plasma-desktopYk1904.jpg
>> Regards
>> Rohan Garg
>>
>>
>>
>> On Tue, Feb 15, 2011 at 9:17 PM, Rohan Garg <rohangarg at ubuntu.com> wrote:
>> > Hi
>> > I've recently encountered 2 issues after pulling this commit, the
>> > first one being that the title of rekonq's window does not seem to
>> > change when navigating web pages, and the second being artifacts in
>> > the tabbar as show here [1].
>> > So i'd like get this patch reverted and re-opened for review and
>> > commit it later on in case everyone else is having the same issue.
>> >
>> > [1] http://wstaw.org/m/2011/02/15/plasma-desktoprJ1904.jpg
>> > Regards
>> > Rohan Garg
>> >
>> _______________________________________________
>> rekonq mailing list
>> rekonq at kde.org
>> https://mail.kde.org/mailman/listinfo/rekonq
>
> HI Rohan,
> me and Benjamin reviewed the patch. Benjamin and Johannes spent all the
last weekend to review it.
> I checked it too and I obviously also tested it and this never happened
here. Either the title or the tabbar problem.
> Are you sure this really depends on this patch?
>
> --
> Andrea Diamantini, adjam
> GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F
>
> rekonq project
> WEB: http://rekonq.kde.org
> IRC: rekonq at freenode
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110216/2e838348/attachment-0001.htm