[rekonq] Re: Review Request: clean up encodings management

Andrea Diamantini adjam7 at gmail.com
Sun Feb 13 01:12:28 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100628/
-----------------------------------------------------------

(Updated Feb. 13, 2011, 12:12 a.m.)


Review request for rekonq.


Summary
-------

This patch cleans up encoding management, moving code to its real position: The appearance settings widget.                                                                                    
                                                        
In fact our code is actually changing "default" text encoding, not the page one "on the fly"


Diffs (updated)
-----

  src/application.cpp 95aa9cf0b0a40006c5c0e1663acce506e4c4e123 
  src/mainwindow.h 33fd20212b9bb69d9450298e4e43324885f8bdf0 
  src/mainwindow.cpp f662d7aa77d8045372c43514c6a04ea497a9afbc 
  src/rekonq.kcfg 33a07751bef787da86e86c7dfac811a6251f456f 
  src/settings/appearancewidget.h e269617233206a0bf43be9e2ed3cac7241e4b8f3 
  src/settings/appearancewidget.cpp c444f72421fd941c69fab4ecb4a916967389bbf2 
  src/settings/settings_appearance.ui f7dd4747f6b3b021fc0ec87c72fb6940967e2b46 
  src/webpage.cpp b04c5e89f5ba4c24c58d2f28fc1fa74a106e4088 
  src/webview.h 9518b74d6640d203d14e8846432cb0dcd60ab955 
  src/webview.cpp 7664805ff9f5388e5ff11dca2b7430d4e8114f87 

Diff: http://git.reviewboard.kde.org/r/100628/diff


Testing
-------

apply, compile, execute, test :)


Thanks,

Andrea

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110213/72d34caf/attachment.html 


More information about the rekonq mailing list