[rekonq] Re: Review Request: replace web shortcuts references by search engine

Andrea Diamantini adjam7 at gmail.com
Tue Feb 8 17:20:11 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100608/#review1307
-----------------------------------------------------------


We are actually supporting also SC 4.5 so you should probably add a check there to use that icon.

- Andrea


On Feb. 8, 2011, 10:38 a.m., Lionel Chauvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100608/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2011, 10:38 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Replace "preferences-web-browser-shortcuts" icon by "edit-web-search" (made by Nuno and available in kde 4.6).
> Replace "Webshortcuts" title by "Search engines" in the settings panel.
> 
> 
> Diffs
> -----
> 
>   src/settings/settingsdialog.cpp 4a8776a 
>   src/urlbar/urlbar.cpp f963be0 
>   src/urlbar/webshortcutwidget.cpp 629e7fb 
> 
> Diff: http://git.reviewboard.kde.org/r/100608/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/100608/s/74/
> 
>   http://git.reviewboard.kde.org/r/100608/s/75/
> 
> 
> Thanks,
> 
> Lionel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110208/d9a4750c/attachment.htm 


More information about the rekonq mailing list