[rekonq] Re: Review Request: highlight updated tabs

Johannes Tröscher fritz_van_tom at hotmail.com
Fri Feb 4 12:25:05 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/
-----------------------------------------------------------

(Updated Feb. 4, 2011, 11:25 a.m.)


Review request for rekonq.


Changes
-------

uses QGraphicsEffect again and highlights the text only. i think i got it right this time :D


Summary
-------

This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).

I don't have a kde git account, so please merge it if you like it.


Diffs (updated)
-----

  src/CMakeLists.txt 7f9fe19 
  src/mainview.cpp 66c86bc 
  src/tabbar.h b505f78 
  src/tabbar.cpp 7a8419a 
  src/tabhighlighteffect.h PRE-CREATION 
  src/tabhighlighteffect.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100230/diff


Testing
-------

compiles and works


Thanks,

Johannes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110204/1fac4421/attachment.htm 


More information about the rekonq mailing list