[rekonq] Re: Review Request: The find bar is now closed with esc even with a shortcut override

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100538/#review1183
-----------------------------------------------------------



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100538/#comment986>

    Unnecessary empty line.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100538/#comment988>

    Too long comment IMHO. A single line explaining the corner case could be better.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100538/#comment987>

    Coding style: QKeyEvent *key, or even QKeyEvent *const key;.
    And static_cast<QKeyEvent*>


- Benjamin


On Feb. 3, 2011, 9:12 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100538/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2011, 9:12 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When the user defines a custom action for the esc key, the findbar isn't hidden with this key. This patch solves it.
> 
> 
> This addresses bug 264929.
>     /show_bug.cgi?id=264929
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 598d66e 
>   src/mainwindow.cpp 943f877 
> 
> Diff: http://git.reviewboard.kde.org/r/100538/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110203/03321b4c/attachment.htm