[rekonq] Re: Review Request: Restore the tab's history when restoring a tab/session

[Anton Kreuzkamp]

> On April 9, 2011, 10:03 p.m., Andrea Diamantini wrote:
> > This patch is not working here.
> 
> Anton Kreuzkamp wrote:
>     What's the problem? Does it not compile? (error-message?) Does it crash? (backtrace?) Or does it simply not work? (what exactly? open a closed tab/restoring the session/both? what does the session-file look like?(is it xml?))
> 
> Felix Rohrbach wrote:
>     This patch is working for me with rekonq-git (at least I found no errors).
> 
> Andrea Diamantini wrote:
>     not working in the sense that no history is saved. At least I don't see it on restore.

Does the session-file exist (should be ~/.kde/share/apps/rekonq/session)? How does it look like?


- Anton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100604/#review2533
-----------------------------------------------------------


On April 8, 2011, 2:51 p.m., Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100604/
> -----------------------------------------------------------
> 
> (Updated April 8, 2011, 2:51 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Restore the history of the tab when restoring a tab from the list of closed tabs, by open last closed tab or by restoring the session.
> Therefore I ported the session-file to xml, as it allows more complex session-files (which is also needed for multiple sessions support).
> (Doesn't require a qtwebkit-patch anymore)
> 
> 
> Diffs
> -----
> 
>   src/mainview.h acc2d8c 
>   src/application.cpp 1fe936f 
>   src/history/historymanager.h eb8d78d 
>   src/mainview.cpp b34acc3 
>   src/newtabpage.cpp a598066 
>   src/sessionmanager.h 2297290 
>   src/sessionmanager.cpp 68bc635 
>   src/tabbar.cpp 1ab357f 
> 
> Diff: http://git.reviewboard.kde.org/r/100604/diff
> 
> 
> Testing
> -------
> 
> tested and everything seems to work fine.
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110424/76023270/attachment.htm