[rekonq] Re: Review Request: firefox-like autoscroll look

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101068/#review2526
-----------------------------------------------------------


Seems good here. Solve the "copyright" issues and I'll merge.

- Andrea


On April 9, 2011, 5:18 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101068/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 5:18 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> warning: this description is a bit shitty, so better look at the screenshot or try autoscrolling in firefox ;)
> 
> ---description---
> in firefox the origin of the autoscrolling is marked with an icon and the cursur stays the same.
> 
> ---about the icon---
> at the moment there is no autoscroll-icon available in oxygen-icons, so i use the one from firefox for now.
> i'm about to write an icon-request for the oxygen-team.
> 
> the second screenshot is the icon from firefox, you have to put it in src/data/ to use the patch.
> i've found no way to include it in the patch.
> 
> 
> Diffs
> -----
> 
>   src/data/CMakeLists.txt 6aef22e 
>   src/webview.h 1fec1ae 
>   src/webview.cpp f72041b 
> 
> Diff: http://git.reviewboard.kde.org/r/101068/diff
> 
> 
> Testing
> -------
> 
> compiles and works.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101068/s/120/
> 
>   http://git.reviewboard.kde.org/r/101068/s/121/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110409/aec338c1/attachment.htm